[shell] Remove unneeded #include

[evince.git] / backend / comics / comics-document.c

diff --git a/backend/comics/comics-document.c b/backend/comics/comics-document.c
index 8928422830ed283f58d7da54e3853e5aefc9ea46..272761f55cded015a12a5f0339b998687341138b 100644 (file)
--- a/backend/comics/comics-document.c
+++ b/backend/comics/comics-document.c
@@ -15,7 +15,7 @@
  *
  * You should have received a copy of the GNU General Public License
  * along with this program; if not, write to the Free Software
  *
  * You should have received a copy of the GNU General Public License
  * along with this program; if not, write to the Free Software

- * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.

  */
 
 #include <config.h>
  */
 
 #include <config.h>


@@ -42,6 +42,16 @@
 #include "ev-document-thumbnails.h"
 #include "ev-file-helpers.h"
 
 #include "ev-document-thumbnails.h"
 #include "ev-file-helpers.h"
 

+#ifdef G_OS_WIN32
+/* On windows g_spawn_command_line_sync reads stdout in O_BINARY mode, not in O_TEXT mode.
+ * As a consequence, newlines are in a platform dependent representation (\r\n). This
+ * might be considered a bug in glib.
+ */
+#define EV_EOL "\r\n"
+#else
+#define EV_EOL "\n"
+#endif
+

 typedef enum
 {
        RARLABS,
 typedef enum
 {
        RARLABS,


@@ -109,7 +119,7 @@ static const ComicBookDecompressCommand command_usage_def[] = {
        {"%s -xOf"          , "%s -tf %s"      , NULL             , NO_OFFSET}
 };
 
        {"%s -xOf"          , "%s -tf %s"      , NULL             , NO_OFFSET}
 };
 

-static void       comics_document_document_thumbnails_iface_init (EvDocumentThumbnailsIface *iface);
+static void       comics_document_document_thumbnails_iface_init (EvDocumentThumbnailsInterface *iface);

 
 static GSList*    get_supported_image_extensions (void);
 static void       get_page_size_area_prepared_cb (GdkPixbufLoader *loader,
 
 static GSList*    get_supported_image_extensions (void);
 static void       get_page_size_area_prepared_cb (GdkPixbufLoader *loader,


@@ -414,7 +424,8 @@ comics_document_load (EvDocument *document,
        }
 
        /* FIXME: is this safe against filenames containing \n in the archive ? */
        }
 
        /* FIXME: is this safe against filenames containing \n in the archive ? */

-       cb_files = g_strsplit (std_out, "\n", 0);
+       cb_files = g_strsplit (std_out, EV_EOL, 0);
+

        g_free (std_out);
 
        if (!cb_files) {
        g_free (std_out);
 
        if (!cb_files) {


@@ -504,7 +515,7 @@ comics_document_get_page_size (EvDocument *document,
        guchar buf[1024];
        gboolean success, got_size = FALSE;
        gint outpipe = -1;
        guchar buf[1024];
        gboolean success, got_size = FALSE;
        gint outpipe = -1;

-       GPid child_pid = -1;
+       GPid child_pid;

        gssize bytes;
        GdkPixbuf *pixbuf;
        gchar *filename;
        gssize bytes;
        GdkPixbuf *pixbuf;
        gchar *filename;


@@ -579,7 +590,7 @@ comics_document_render_pixbuf (EvDocument      *document,
        guchar buf[4096];
        gboolean success;
        gint outpipe = -1;
        guchar buf[4096];
        gboolean success;
        gint outpipe = -1;

-       GPid child_pid = -1;
+       GPid child_pid;

        gssize bytes;
        gint width, height;
        gchar *filename;
        gssize bytes;
        gint width, height;
        gchar *filename;


@@ -809,7 +820,7 @@ comics_document_thumbnails_get_dimensions (EvDocumentThumbnails *document,
 }
 
 static void
 }
 
 static void

-comics_document_document_thumbnails_iface_init (EvDocumentThumbnailsIface *iface)
+comics_document_document_thumbnails_iface_init (EvDocumentThumbnailsInterface *iface)

 {
        iface->get_thumbnail = comics_document_thumbnails_get_thumbnail;
        iface->get_dimensions = comics_document_thumbnails_get_dimensions;
 {
        iface->get_thumbnail = comics_document_thumbnails_get_thumbnail;
        iface->get_dimensions = comics_document_thumbnails_get_dimensions;