]> www.fi.muni.cz Git - evince.git/blobdiff - shell/ev-sidebar.c
Fix a crash in debug mode. Patch by Daniel M German.
[evince.git] / shell / ev-sidebar.c
index f687d10f4dc379ac38e061021b4370fbb37a654a..06a29c78eb9830e7015777f31f2cd3835b5ac9c3 100644 (file)
 
 #include "ev-sidebar.h"
 #include "ev-sidebar-page.h"
-#include "ev-document-thumbnails.h"
-#include "ev-document-links.h"
+
+enum
+{
+       PROP_0,
+       PROP_CURRENT_PAGE
+};
 
 enum
 {
@@ -44,6 +48,7 @@ enum
 
 struct _EvSidebarPrivate {
        GtkWidget *notebook;
+       GtkWidget *select_button;
        GtkWidget *menu;
        GtkWidget *hbox;
        GtkWidget *label;
@@ -65,10 +70,106 @@ ev_sidebar_destroy (GtkObject *object)
                gtk_menu_detach (GTK_MENU (ev_sidebar->priv->menu));
                ev_sidebar->priv->menu = NULL;
        }
+       
+       if (ev_sidebar->priv->page_model) {
+               g_object_unref (ev_sidebar->priv->page_model);
+               ev_sidebar->priv->page_model = NULL;
+       }
+               
           
        (* GTK_OBJECT_CLASS (ev_sidebar_parent_class)->destroy) (object);
 }
 
+static void
+ev_sidebar_select_page (EvSidebar *ev_sidebar,  GtkTreeIter *iter)
+{
+       char *title;
+       int index;
+
+       gtk_tree_model_get (ev_sidebar->priv->page_model, iter,
+                           PAGE_COLUMN_TITLE, &title, 
+                           PAGE_COLUMN_NOTEBOOK_INDEX, &index,
+                           -1);
+
+       gtk_notebook_set_current_page (GTK_NOTEBOOK (ev_sidebar->priv->notebook), index);
+       gtk_label_set_text (GTK_LABEL (ev_sidebar->priv->label), title);
+
+       g_free (title);
+}
+
+void
+ev_sidebar_set_page (EvSidebar   *ev_sidebar,
+                    GtkWidget   *main_widget)
+{
+       GtkTreeIter iter;
+       gboolean valid;
+
+       valid = gtk_tree_model_get_iter_first (ev_sidebar->priv->page_model, &iter);
+          
+       while (valid) {
+               GtkWidget *widget;
+
+               gtk_tree_model_get (ev_sidebar->priv->page_model, &iter,
+                                   PAGE_COLUMN_MAIN_WIDGET, &widget,
+                                   -1);
+                        
+               if (widget == main_widget) {
+                       ev_sidebar_select_page (ev_sidebar, &iter);
+                       valid = FALSE;
+               } else {
+                       valid = gtk_tree_model_iter_next (ev_sidebar->priv->page_model, &iter);
+               }
+               g_object_unref (widget);
+       }
+
+       g_object_notify (G_OBJECT (ev_sidebar), "current-page");
+}
+
+static void
+ev_sidebar_set_property (GObject      *object,
+                        guint         prop_id,
+                        const GValue *value,
+                        GParamSpec   *pspec)
+{
+       EvSidebar *sidebar = EV_SIDEBAR (object);
+
+       switch (prop_id)
+       {
+       case PROP_CURRENT_PAGE:
+               ev_sidebar_set_page (sidebar, g_value_get_object (value));      
+               break;
+       default:
+               G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
+       }
+}
+
+static GtkWidget *
+ev_sidebar_get_current_page (EvSidebar *sidebar)
+{
+       GtkNotebook *notebook = GTK_NOTEBOOK (sidebar->priv->notebook);
+
+       return gtk_notebook_get_nth_page
+               (notebook, gtk_notebook_get_current_page (notebook));
+}
+
+static void
+ev_sidebar_get_property (GObject *object,
+                        guint prop_id,
+                        GValue *value,
+                        GParamSpec *pspec)
+{
+       EvSidebar *sidebar = EV_SIDEBAR (object);
+
+       switch (prop_id)
+       {
+       case PROP_CURRENT_PAGE:
+               g_value_set_object (value, ev_sidebar_get_current_page (sidebar));
+               break;
+       default:
+               G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
+       }
+}
+
 static void
 ev_sidebar_class_init (EvSidebarClass *ev_sidebar_class)
 {
@@ -83,6 +184,16 @@ ev_sidebar_class_init (EvSidebarClass *ev_sidebar_class)
        g_type_class_add_private (g_object_class, sizeof (EvSidebarPrivate));
           
        gtk_object_klass->destroy = ev_sidebar_destroy;
+       g_object_class->get_property = ev_sidebar_get_property;
+       g_object_class->set_property = ev_sidebar_set_property;
+
+       g_object_class_install_property (g_object_class,
+                                        PROP_CURRENT_PAGE,
+                                        g_param_spec_object ("current-page",
+                                                             "Current page",
+                                                             "The currently visible page",
+                                                             GTK_TYPE_WIDGET,
+                                                             G_PARAM_READWRITE));
 }
 
 static void
@@ -194,30 +305,26 @@ ev_sidebar_menu_item_activate_cb (GtkWidget *widget,
        EvSidebar *ev_sidebar = EV_SIDEBAR (user_data);
        GtkTreeIter iter;
        GtkWidget *menu_item, *item;
-       gchar *title;
        gboolean valid;
-       gint index;
 
        menu_item = gtk_menu_get_active (GTK_MENU (ev_sidebar->priv->menu));
        valid = gtk_tree_model_get_iter_first (ev_sidebar->priv->page_model, &iter);
           
        while (valid) {
-               gtk_tree_model_get (ev_sidebar->priv->page_model,
-                                   &iter,
-                                   PAGE_COLUMN_TITLE, &title, 
+               gtk_tree_model_get (ev_sidebar->priv->page_model, &iter,
                                    PAGE_COLUMN_MENU_ITEM, &item,
-                                   PAGE_COLUMN_NOTEBOOK_INDEX, &index,
                                    -1);
                         
                if (item == menu_item) {
-                       gtk_notebook_set_current_page
-                               (GTK_NOTEBOOK (ev_sidebar->priv->notebook), index);
-                       gtk_label_set_text (GTK_LABEL (ev_sidebar->priv->label), title);
+                       ev_sidebar_select_page (ev_sidebar, &iter);
                        valid = FALSE;
                } else {
                        valid = gtk_tree_model_iter_next (ev_sidebar->priv->page_model, &iter);
                }
+               g_object_unref (item);
        }
+
+       g_object_notify (G_OBJECT (ev_sidebar), "current-page");
 }
 
 static void
@@ -225,7 +332,6 @@ ev_sidebar_init (EvSidebar *ev_sidebar)
 {
        GtkWidget *hbox;
        GtkWidget *close_button;
-       GtkWidget *select_button;
        GtkWidget *select_hbox;
        GtkWidget *arrow;
        GtkWidget *image;
@@ -246,12 +352,12 @@ ev_sidebar_init (EvSidebar *ev_sidebar)
        gtk_box_pack_start (GTK_BOX (ev_sidebar), hbox, FALSE, FALSE, 0);
        gtk_widget_show (hbox);
 
-       select_button = gtk_toggle_button_new ();
-       gtk_button_set_relief (GTK_BUTTON (select_button), GTK_RELIEF_NONE);
-       g_signal_connect (select_button, "button_press_event",
+       ev_sidebar->priv->select_button = gtk_toggle_button_new ();
+       gtk_button_set_relief (GTK_BUTTON (ev_sidebar->priv->select_button), GTK_RELIEF_NONE);
+       g_signal_connect (ev_sidebar->priv->select_button, "button_press_event",
                          G_CALLBACK (ev_sidebar_select_button_press_cb),
                          ev_sidebar);
-       g_signal_connect (select_button, "key_press_event",
+       g_signal_connect (ev_sidebar->priv->select_button, "key_press_event",
                          G_CALLBACK (ev_sidebar_select_button_key_press_cb),
                          ev_sidebar);
 
@@ -267,11 +373,11 @@ ev_sidebar_init (EvSidebar *ev_sidebar)
        gtk_box_pack_end (GTK_BOX (select_hbox), arrow, FALSE, FALSE, 0);
        gtk_widget_show (arrow);
 
-       gtk_container_add (GTK_CONTAINER (select_button), select_hbox);
+       gtk_container_add (GTK_CONTAINER (ev_sidebar->priv->select_button), select_hbox);
        gtk_widget_show (select_hbox);
 
-       gtk_box_pack_start (GTK_BOX (hbox), select_button, TRUE, TRUE, 0);
-       gtk_widget_show (select_button);
+       gtk_box_pack_start (GTK_BOX (hbox), ev_sidebar->priv->select_button, TRUE, TRUE, 0);
+       gtk_widget_show (ev_sidebar->priv->select_button);
 
        close_button = gtk_button_new ();
        gtk_button_set_relief (GTK_BUTTON (close_button), GTK_RELIEF_NONE);
@@ -280,7 +386,7 @@ ev_sidebar_init (EvSidebar *ev_sidebar)
                          ev_sidebar);
           
        image = gtk_image_new_from_stock (GTK_STOCK_CLOSE,
-                                         GTK_ICON_SIZE_SMALL_TOOLBAR);
+                                         GTK_ICON_SIZE_MENU);
        gtk_container_add (GTK_CONTAINER (close_button), image);
        gtk_widget_show (image);
    
@@ -290,7 +396,7 @@ ev_sidebar_init (EvSidebar *ev_sidebar)
        ev_sidebar->priv->menu = gtk_menu_new ();
        g_signal_connect (ev_sidebar->priv->menu, "deactivate",
                          G_CALLBACK (ev_sidebar_menu_deactivate_cb),
-                         select_button);
+                         ev_sidebar->priv->select_button);
        gtk_menu_attach_to_widget (GTK_MENU (ev_sidebar->priv->menu),
                                   GTK_WIDGET (ev_sidebar),
                                   ev_sidebar_menu_detach_cb);
@@ -303,7 +409,8 @@ ev_sidebar_init (EvSidebar *ev_sidebar)
                            TRUE, TRUE, 0);
        gtk_widget_show (ev_sidebar->priv->notebook);
 
-       gtk_widget_set_sensitive (GTK_WIDGET (ev_sidebar), FALSE);
+       gtk_widget_set_sensitive (GTK_WIDGET (ev_sidebar->priv->notebook), FALSE);
+       gtk_widget_set_sensitive (GTK_WIDGET (ev_sidebar->priv->select_button), FALSE);
 }
 
 /* Public functions */
@@ -344,7 +451,8 @@ ev_sidebar_add_page (EvSidebar   *ev_sidebar,
        gtk_widget_show (menu_item);
        gtk_menu_shell_append (GTK_MENU_SHELL (ev_sidebar->priv->menu),
                               menu_item);
-          
+
+       /* Insert and move to end */
        gtk_list_store_insert_with_values (GTK_LIST_STORE (ev_sidebar->priv->page_model),
                                           &iter, 0,
                                           PAGE_COLUMN_TITLE, title,
@@ -352,7 +460,10 @@ ev_sidebar_add_page (EvSidebar   *ev_sidebar,
                                           PAGE_COLUMN_MAIN_WIDGET, main_widget,
                                           PAGE_COLUMN_NOTEBOOK_INDEX, index,
                                           -1);
-          
+       gtk_list_store_move_before(GTK_LIST_STORE(ev_sidebar->priv->page_model),
+                                          &iter, NULL);
+
+
        /* Set the first item added as active */
        gtk_tree_model_get_iter_first (ev_sidebar->priv->page_model, &iter);
        gtk_tree_model_get (ev_sidebar->priv->page_model,
@@ -365,6 +476,7 @@ ev_sidebar_add_page (EvSidebar   *ev_sidebar,
        gtk_label_set_text (GTK_LABEL (ev_sidebar->priv->label), label_title);
        gtk_notebook_set_current_page (GTK_NOTEBOOK (ev_sidebar->priv->notebook),
                                       index);
+       g_free (label_title);
 }
 
 void
@@ -401,12 +513,15 @@ ev_sidebar_set_document (EvSidebar   *sidebar,
                } else {
                                gtk_widget_set_sensitive (menu_widget, FALSE);
                }
+               g_object_unref (widget);
+               g_object_unref (menu_widget);
        }
        
        if (!has_pages) {
                gtk_widget_hide (GTK_WIDGET (sidebar));
        } else {
-               gtk_widget_set_sensitive (GTK_WIDGET (sidebar), TRUE);
+               gtk_widget_set_sensitive (GTK_WIDGET (sidebar->priv->notebook), TRUE);
+               gtk_widget_set_sensitive (GTK_WIDGET (sidebar->priv->select_button), TRUE);
        }
 }