[print] Fixes segmentation violation when format is empty

[evince.git] / shell / ev-window-title.c

diff --git a/shell/ev-window-title.c b/shell/ev-window-title.c
index b43775a62e122b1af4932b0f2358c88106016173..baafa74f399278d607418375085c43efb0c1d0d0 100644 (file)
--- a/shell/ev-window-title.c
+++ b/shell/ev-window-title.c
@@ -20,7 +20,9 @@
 #include <config.h>
 #include "ev-window-title.h"
 #include "ev-backends-manager.h"
+#include "ev-utils.h"
 
+#include <string.h>
 #include <gio/gio.h>
 #include <glib/gi18n.h>
 
@@ -31,8 +33,8 @@
 typedef struct
 {
        const gchar *backend;
-       const gchar *ext;
-} BadExtensionEntry;
+       const gchar *text;
+} BadTitleEntry;
 
 struct _EvWindowTitle
 {
@@ -42,7 +44,7 @@ struct _EvWindowTitle
        char *uri;
 };
 
-static const BadExtensionEntry bad_extensions[] = {
+static const BadTitleEntry bad_extensions[] = {
        { EV_BACKEND_PS, ".dvi" },
        { EV_BACKEND_PDF, ".doc" },
        { EV_BACKEND_PDF, ".dvi" },
@@ -50,6 +52,11 @@ static const BadExtensionEntry bad_extensions[] = {
        { EV_BACKEND_PDF, ".rtf" }
 };
 
+static const BadTitleEntry bad_prefixes[] = {
+       { EV_BACKEND_PDF, "Microsoft Word - " },
+       { EV_BACKEND_PDF, "Microsoft PowerPoint - " }
+};
+
 EvWindowTitle *
 ev_window_title_new (EvWindow *window)
 {
@@ -65,20 +72,20 @@ ev_window_title_new (EvWindow *window)
 static char *
 get_filename_from_uri (const char *uri)
 {
-       GFile *file;
        char *filename;
+       char *basename;
        
-       file = g_file_new_for_uri (uri);
-       filename = g_file_get_basename (file);
-       g_object_unref (file);
+       filename = escape_uri_for_display (uri);
+       basename = g_path_get_basename (filename);
+       g_free(filename);
 
-       return filename;
+       return basename;
 }
 
 /* Some docs report titles with confusing extensions (ex. .doc for pdf).
    Let's show the filename in this case */
 static void
-ev_window_title_sanitize_extension (EvWindowTitle *window_title, char **title) {
+ev_window_title_sanitize_title (EvWindowTitle *window_title, char **title) {
        const gchar *backend;
        int i;
 
@@ -86,7 +93,7 @@ ev_window_title_sanitize_extension (EvWindowTitle *window_title, char **title) {
 
        for (i = 0; i < G_N_ELEMENTS (bad_extensions); i++) {
                if (g_ascii_strcasecmp (bad_extensions[i].backend, backend) == 0 && 
-                   g_str_has_suffix (*title, bad_extensions[i].ext)) {
+                   g_str_has_suffix (*title, bad_extensions[i].text)) {
                        char *new_title;
                        char *filename = get_filename_from_uri (window_title->uri);
 
@@ -97,6 +104,17 @@ ev_window_title_sanitize_extension (EvWindowTitle *window_title, char **title) {
                        g_free (filename);
                }
        }
+       for (i = 0; i < G_N_ELEMENTS (bad_prefixes); i++) {
+               if (g_ascii_strcasecmp (bad_prefixes[i].backend, backend) == 0 &&
+                   g_str_has_prefix (*title, bad_prefixes[i].text)) {
+                       char *new_title;
+                       int len = strlen(bad_prefixes[i].text);
+                       
+                       new_title = g_strdup_printf ("%s", (*title) + len);
+                       g_free (*title);
+                       *title = new_title;
+               }
+       }
 }
 
 static void
@@ -125,7 +143,7 @@ ev_window_title_update (EvWindowTitle *window_title)
        }
 
        if (title && window_title->uri) {
-               ev_window_title_sanitize_extension (window_title, &title);
+               ev_window_title_sanitize_title (window_title, &title);
        } else if (window_title->uri) {
                title = get_filename_from_uri (window_title->uri);
        } else if (!title) {