X-Git-Url: https://www.fi.muni.cz/~kas/git//home/kas/public_html/git/?a=blobdiff_plain;ds=inline;f=shell%2Fev-sidebar-links.c;h=58dac08ca9f835ed39c9688dc128c00bf8a3f80d;hb=65c06150e05948eb7b056b0ec5cb9c364b652cfe;hp=84b49dd292b47175aa5c0ac03df28e149082aba5;hpb=4f1722b0523879cd73ee936d483a735e163a6b54;p=evince.git

diff --git a/shell/ev-sidebar-links.c b/shell/ev-sidebar-links.c
index 84b49dd2..58dac08c 100644
--- a/shell/ev-sidebar-links.c
+++ b/shell/ev-sidebar-links.c
@@ -143,12 +143,6 @@ ev_sidebar_links_dispose (GObject *object)
 {
 	EvSidebarLinks *sidebar = EV_SIDEBAR_LINKS (object);
 
-	if (sidebar->priv->document) {
-		g_object_unref (sidebar->priv->document);
-		sidebar->priv->document = NULL;
-		sidebar->priv->page_cache = NULL;
-	}
-
 	if (sidebar->priv->job) {
 		g_signal_handlers_disconnect_by_func (sidebar->priv->job,
 						      job_finished_callback, sidebar);
@@ -157,6 +151,18 @@ ev_sidebar_links_dispose (GObject *object)
 		sidebar->priv->job = NULL;
 	}
 
+	if (sidebar->priv->model) {
+		g_object_unref (sidebar->priv->model);
+		sidebar->priv->model = NULL;
+	}
+
+	if (sidebar->priv->document) {
+		g_object_unref (sidebar->priv->document);
+		sidebar->priv->document = NULL;
+		sidebar->priv->page_cache = NULL;
+	}
+
+
 	G_OBJECT_CLASS (ev_sidebar_links_parent_class)->dispose (object);
 }
 
@@ -214,6 +220,8 @@ selection_changed_callback (GtkTreeSelection   *selection,
 		ev_page_cache_set_link (ev_sidebar_links->priv->page_cache, link);
 		g_signal_handler_unblock (ev_sidebar_links->priv->page_cache,
 					  ev_sidebar_links->priv->page_changed_id);
+
+		g_object_unref (link);
 	}
 }
 
@@ -262,11 +270,17 @@ print_section_cb (GtkWidget *menuitem, EvSidebarLinks *sidebar)
 				    -1);
 		first_page = ev_link_get_page (link) + 1;
 
+		if (link)
+			g_object_unref (link);
+
 		if (gtk_tree_model_iter_next (model, &iter)) {
 			gtk_tree_model_get (model, &iter,
 					    EV_DOCUMENT_LINKS_COLUMN_LINK, &link,
 					    -1);
 			last_page = ev_link_get_page (link);
+
+			if (link)
+		    		g_object_unref (link);
 		} else {
 			last_page = -1;
 		}
@@ -439,6 +453,9 @@ links_page_num_func (GtkTreeViewColumn *tree_column,
 			      "visible", FALSE,
 			      NULL);
 	}
+
+	if (link)
+		g_object_unref (link);
 }
 
 /* Public Functions */
@@ -476,10 +493,14 @@ update_page_callback_foreach (GtkTreeModel *model,
 			selection = gtk_tree_view_get_selection (GTK_TREE_VIEW (sidebar_links->priv->tree_view));
 
 			gtk_tree_selection_select_path (selection, path);
-
+	
+			g_object_unref (link);
 			return TRUE;
 		}
 	}
+
+	if (link)
+		g_object_unref (link);
 	
 	return FALSE;
 }
@@ -529,13 +550,11 @@ static void
 expand_open_links (GtkTreeView *tree_view, GtkTreeModel *model, GtkTreeIter *parent)
 {
 	GtkTreeIter iter;
-	EvLink *link;
 	gboolean expand;
 
 	if (gtk_tree_model_iter_children (model, &iter, parent)) {
 		do {
 			gtk_tree_model_get (model, &iter,
-					    EV_DOCUMENT_LINKS_COLUMN_LINK, &link,
 					    EV_DOCUMENT_LINKS_COLUMN_EXPAND, &expand,
 					    -1);
 			if (expand) {
@@ -559,11 +578,12 @@ job_finished_callback (EvJobLinks     *job,
 	GtkTreeSelection *selection;
 
 	priv = sidebar_links->priv;
-
-	priv->model = g_object_ref (job->model);
+	
+	priv->model = job->model;
 	g_object_notify (G_OBJECT (sidebar_links), "model");
 
 	gtk_tree_view_set_model (GTK_TREE_VIEW (priv->tree_view), job->model);
+	
 	g_object_unref (job);
 	priv->job = NULL;