2005-02-07 Marco Pesenti Gritti <marco@gnome.org>
* shell/ev-page-view.c: (ev_page_view_dispose):
* shell/ev-view.c: (ev_view_finalize):
* shell/ev-window.c: (ev_window_setup_document),
(ev_window_dispose), (ev_window_init):
Solve more refs issues.
I commented out the page_view initialization for now:
it was never destroyed (because it's never added
to a container). Because of that we was leaking
gs processes. Couldnt think to a clean fix.
We need to figure this out, password view has the
same issue probably.
+2005-02-07 Marco Pesenti Gritti <marco@gnome.org>
+
+ * shell/ev-page-view.c: (ev_page_view_dispose):
+ * shell/ev-view.c: (ev_view_finalize):
+ * shell/ev-window.c: (ev_window_setup_document),
+ (ev_window_dispose), (ev_window_init):
+
+ Solve more refs issues.
+
+ I commented out the page_view initialization for now:
+ it was never destroyed (because it's never added
+ to a container). Because of that we was leaking
+ gs processes. Couldnt think to a clean fix.
+ We need to figure this out, password view has the
+ same issue probably.
+
2005-02-07 Marco Pesenti Gritti <marco@gnome.org>
* ps/ps-document.c: (ps_document_finalize),
2005-02-07 Marco Pesenti Gritti <marco@gnome.org>
* ps/ps-document.c: (ps_document_finalize),
#include "ev-page-view.h"
#include "ev-marshal.h"
#include "ev-document-misc.h"
#include "ev-page-view.h"
#include "ev-marshal.h"
#include "ev-document-misc.h"
#include <gtk/gtk.h>
/* We keep a cached array of all the page sizes. The info is accessed via
#include <gtk/gtk.h>
/* We keep a cached array of all the page sizes. The info is accessed via
{
EvPageView *view = EV_PAGE_VIEW (object);
{
EvPageView *view = EV_PAGE_VIEW (object);
if (view->priv->document) {
g_object_unref (view->priv->document);
view->priv->document = NULL;
if (view->priv->document) {
g_object_unref (view->priv->document);
view->priv->document = NULL;
{
EvView *view = EV_VIEW (object);
{
EvView *view = EV_VIEW (object);
if (view->document)
g_object_unref (view->document);
if (view->document)
g_object_unref (view->document);
{
EvDocument *document;
EvView *view = EV_VIEW (ev_window->priv->view);
{
EvDocument *document;
EvView *view = EV_VIEW (ev_window->priv->view);
- EvPageView *page_view = EV_PAGE_VIEW (ev_window->priv->page_view);
+ //EvPageView *page_view = EV_PAGE_VIEW (ev_window->priv->page_view);
EvSidebar *sidebar = EV_SIDEBAR (ev_window->priv->sidebar);
document = ev_window->priv->document;
EvSidebar *sidebar = EV_SIDEBAR (ev_window->priv->sidebar);
document = ev_window->priv->document;
ev_sidebar_set_document (sidebar, document);
ev_view_set_document (view, document);
ev_sidebar_set_document (sidebar, document);
ev_view_set_document (view, document);
- ev_page_view_set_document (page_view, document);
+ //ev_page_view_set_document (page_view, document);
update_window_title (document, NULL, ev_window);
update_total_pages (ev_window);
update_window_title (document, NULL, ev_window);
update_total_pages (ev_window);
g_object_unref (priv->document);
priv->document = NULL;
}
g_object_unref (priv->document);
priv->document = NULL;
}
+
+ if (priv->view) {
+ g_object_unref (priv->view);
+ priv->view = NULL;
+ }
+
+ if (priv->page_view) {
+ g_object_unref (priv->page_view);
+ priv->page_view = NULL;
+ }
+
if (priv->password_document) {
g_object_unref (priv->password_document);
priv->password_document = NULL;
if (priv->password_document) {
g_object_unref (priv->password_document);
priv->password_document = NULL;
ev_window->priv->scrolled_window);
ev_window->priv->view = ev_view_new ();
ev_window->priv->scrolled_window);
ev_window->priv->view = ev_view_new ();
- ev_window->priv->page_view = ev_page_view_new ();
+ //ev_window->priv->page_view = ev_page_view_new ();
ev_window->priv->password_view = ev_password_view_new ();
g_signal_connect_swapped (ev_window->priv->password_view,
"unlock",
G_CALLBACK (ev_window_popup_password_dialog),
ev_window);
gtk_widget_show (ev_window->priv->view);
ev_window->priv->password_view = ev_password_view_new ();
g_signal_connect_swapped (ev_window->priv->password_view,
"unlock",
G_CALLBACK (ev_window_popup_password_dialog),
ev_window);
gtk_widget_show (ev_window->priv->view);
- gtk_widget_show (ev_window->priv->page_view);
+ //gtk_widget_show (ev_window->priv->page_view);
gtk_widget_show (ev_window->priv->password_view);
/* We own a ref on these widgets, as we can swap them in and out */
g_object_ref (ev_window->priv->view);
gtk_widget_show (ev_window->priv->password_view);
/* We own a ref on these widgets, as we can swap them in and out */
g_object_ref (ev_window->priv->view);
- g_object_ref (ev_window->priv->page_view);
+ //g_object_ref (ev_window->priv->page_view);
g_object_ref (ev_window->priv->password_view);
gtk_container_add (GTK_CONTAINER (ev_window->priv->scrolled_window),
g_object_ref (ev_window->priv->password_view);
gtk_container_add (GTK_CONTAINER (ev_window->priv->scrolled_window),