Make sure find_result is never < 0 which causes a crash while searching.

2008-11-23  Carlos Garcia Campos  <carlosgc@gnome.org>

	* shell/ev-view.c: (ev_view_find_previous):

	Make sure find_result is never < 0 which causes a crash while
	searching. Fixes bug #558377.

svn path=/trunk/; revision=3273

diff --git a/ChangeLog b/ChangeLog
index 343dee7b651aa2870429e6ead0941484e827270e..e8b0304e780ba1f7d07ca36f2fcfeac037f2a9b4 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2008-11-23  Carlos Garcia Campos  <carlosgc@gnome.org>
+
+       * shell/ev-view.c: (ev_view_find_previous):
+
+       Make sure find_result is never < 0 which causes a crash while
+       searching. Fixes bug #558377.
+       
 2008-11-19  Marek Kašík <mkasik@redhat.com>
 
        * shell/ev-pixbuf-cache.c (new_selection_surface_needed),

diff --git a/shell/ev-view.c b/shell/ev-view.c
index 9c575d270d5911651dcb9fbd15ecbf29ae964d1d..02a278325ec63ee8c51fc66306246974782a4cf4 100644 (file)
--- a/shell/ev-view.c
+++ b/shell/ev-view.c
@@ -5181,7 +5181,7 @@ ev_view_find_previous (EvView *view)
 
        if (view->find_result < 0) {
                jump_to_find_page (view, EV_VIEW_FIND_PREV, -1);
-               view->find_result = ev_view_find_get_n_results (view, view->current_page) - 1;
+               view->find_result = MAX (0, ev_view_find_get_n_results (view, view->current_page) - 1);
                jump_to_find_result (view);
        } else {
                jump_to_find_result (view);