]> www.fi.muni.cz Git - evince.git/commitdiff
[shell] Improve findbar message when there are no matches
authorCarlos Garcia Campos <carlosgc@gnome.org>
Sat, 14 Aug 2010 08:56:14 +0000 (10:56 +0200)
committerCarlos Garcia Campos <carlosgc@gnome.org>
Sat, 14 Aug 2010 09:00:16 +0000 (11:00 +0200)
The message "0 found on this page" is confusing when there are no
matches in any page, so now we use just "Not found" in that case. Based
on patch by José Aliste.
Fixes bug #626334.

shell/ev-window.c

index fac2a119748f8ff37bdb3c298e410863d32f31bd..f1d3bd905cb534b88a12eb8a5efb257b456885be 100644 (file)
@@ -4858,17 +4858,23 @@ ev_window_update_find_status_message (EvWindow *ev_window)
                return;
        
        if (ev_job_is_finished (ev_window->priv->find_job)) {
-               gint n_results;
-
-               n_results = ev_job_find_get_n_results (EV_JOB_FIND (ev_window->priv->find_job),
-                                                      ev_document_model_get_page (ev_window->priv->model));
-               /* TRANS: Sometimes this could be better translated as
-                                     "%d hit(s) on this page".  Therefore this string
-                                     contains plural cases. */
-               message = g_strdup_printf (ngettext ("%d found on this page",
-                                                    "%d found on this page",
-                                                    n_results),
-                                          n_results);
+               EvJobFind *job_find = EV_JOB_FIND (ev_window->priv->find_job);
+
+               if (ev_job_find_has_results (job_find)) {
+                       gint n_results;
+
+                       n_results = ev_job_find_get_n_results (job_find,
+                                                              ev_document_model_get_page (ev_window->priv->model));
+                       /* TRANS: Sometimes this could be better translated as
+                          "%d hit(s) on this page".  Therefore this string
+                          contains plural cases. */
+                       message = g_strdup_printf (ngettext ("%d found on this page",
+                                                            "%d found on this page",
+                                                            n_results),
+                                                  n_results);
+               } else {
+                       message = g_strdup (_("Not found"));
+               }
        } else {
                gdouble percent;