From 4dd8f5ed4440055665f564818a762663a8390310 Mon Sep 17 00:00:00 2001 From: Marco Pesenti Gritti Date: Fri, 7 Jan 2005 15:05:52 +0000 Subject: [PATCH] add a FIXME. We should probably not allocate a bookmark object every time 2005-01-07 Marco Pesenti Gritti * pdf/xpdf/pdf-document.cc: add a FIXME. We should probably not allocate a bookmark object every time --- ChangeLog | 7 +++++++ pdf/xpdf/pdf-document.cc | 2 ++ 2 files changed, 9 insertions(+) diff --git a/ChangeLog b/ChangeLog index ca0222cc..1b3fc228 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2005-01-07 Marco Pesenti Gritti + + * pdf/xpdf/pdf-document.cc: + + add a FIXME. We should probably not allocate + a bookmark object every time + 2005-01-07 Marco Pesenti Gritti * shell/ev-application.c: (ev_application_open), diff --git a/pdf/xpdf/pdf-document.cc b/pdf/xpdf/pdf-document.cc index 6e077162..6f137dd9 100644 --- a/pdf/xpdf/pdf-document.cc +++ b/pdf/xpdf/pdf-document.cc @@ -740,6 +740,8 @@ pdf_document_bookmarks_begin_read (EvDocumentBookmarks *document_bookmarks) return (EvDocumentBookmarksIter *) iter; } +/* FIXME This returns a new object every time, probably we should cache it + in the iter */ static EvBookmark * pdf_document_bookmarks_get_bookmark (EvDocumentBookmarks *document_bookmarks, EvDocumentBookmarksIter *bookmarks_iter) -- 2.43.5