From 96f9d9380f25de6c0badcd1d942b1fbf6cb2e1f9 Mon Sep 17 00:00:00 2001 From: Wouter Bolsterlee Date: Thu, 24 Jan 2008 15:06:34 +0000 Subject: [PATCH] Use top/up/bottom/down arrows instead of first/left/last/right in the 2008-01-24 Wouter Bolsterlee * shell/ev-window.c: Use top/up/bottom/down arrows instead of first/left/last/right in the toolbar and menu actions. This fixes issues with RTL languages and is visually consistent with the page view. Fixes bug #170081. svn path=/trunk/; revision=2853 --- ChangeLog | 9 +++++++++ NEWS | 1 + shell/ev-window.c | 8 ++++---- 3 files changed, 14 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index 79310b0d..d8aea77c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,12 @@ +2008-01-24 Wouter Bolsterlee + + * shell/ev-window.c: + + Use top/up/bottom/down arrows instead of + first/left/last/right in the toolbar and menu actions. + This fixes issues with RTL languages and is visually + consistent with the page view. Fixes bug #170081. + 2008-01-24 Wouter Bolsterlee * NEWS: diff --git a/NEWS b/NEWS index 3ea6459f..9b819d35 100644 --- a/NEWS +++ b/NEWS @@ -21,6 +21,7 @@ New features and UI improvements: Ingmarsson, Nickolay V. Shmyrev) * Add support for page transitions (#458460, Carlos Garnacho) * Override document restrictions by default (#382700, Wouter Bolsterlee) + * Use up/down arrows instead of left/right (#170081, Wouter Bolsterlee) Bug fixes: diff --git a/shell/ev-window.c b/shell/ev-window.c index 2fbccd38..9f9924ba 100644 --- a/shell/ev-window.c +++ b/shell/ev-window.c @@ -4414,16 +4414,16 @@ static const GtkActionEntry entries[] = { G_CALLBACK (ev_window_cmd_view_autoscroll) }, /* Go menu */ - { "GoPreviousPage", GTK_STOCK_GO_BACK, N_("_Previous Page"), "Page_Up", + { "GoPreviousPage", GTK_STOCK_GO_UP, N_("_Previous Page"), "Page_Up", N_("Go to the previous page"), G_CALLBACK (ev_window_cmd_go_previous_page) }, - { "GoNextPage", GTK_STOCK_GO_FORWARD, N_("_Next Page"), "Page_Down", + { "GoNextPage", GTK_STOCK_GO_DOWN, N_("_Next Page"), "Page_Down", N_("Go to the next page"), G_CALLBACK (ev_window_cmd_go_next_page) }, - { "GoFirstPage", GTK_STOCK_GOTO_FIRST, N_("_First Page"), "Home", + { "GoFirstPage", GTK_STOCK_GOTO_TOP, N_("_First Page"), "Home", N_("Go to the first page"), G_CALLBACK (ev_window_cmd_go_first_page) }, - { "GoLastPage", GTK_STOCK_GOTO_LAST, N_("_Last Page"), "End", + { "GoLastPage", GTK_STOCK_GOTO_BOTTOM, N_("_Last Page"), "End", N_("Go to the last page"), G_CALLBACK (ev_window_cmd_go_last_page) }, -- 2.43.5