From d1b42341039d4e26cf299c2fc50d36cd18760011 Mon Sep 17 00:00:00 2001 From: Carlos Garcia Campos Date: Wed, 27 Feb 2008 17:32:52 +0000 Subject: [PATCH] Fix a crash when a choice form field doesn't have any item selected. Fixes 2008-02-27 Carlos Garcia Campos * shell/ev-view.c: (ev_view_form_field_choice_changed): Fix a crash when a choice form field doesn't have any item selected. Fixes bug #518831 svn path=/trunk/; revision=2930 --- ChangeLog | 7 +++++++ shell/ev-view.c | 3 ++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index b1de678d..41c94bb6 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2008-02-27 Carlos Garcia Campos + + * shell/ev-view.c: (ev_view_form_field_choice_changed): + + Fix a crash when a choice form field doesn't have any item + selected. Fixes bug #518831 + 2008-02-25 Alexander Larsson * shell/ev-window.c (ev_window_clear_temp_file): diff --git a/shell/ev-view.c b/shell/ev-view.c index dc1d190f..3b7a60dd 100644 --- a/shell/ev-view.c +++ b/shell/ev-view.c @@ -1907,7 +1907,8 @@ ev_view_form_field_choice_changed (GtkWidget *widget, gint item; item = gtk_combo_box_get_active (GTK_COMBO_BOX (widget)); - if (GPOINTER_TO_INT (field_choice->selected_items->data) != item) { + if (!field_choice->selected_items || + GPOINTER_TO_INT (field_choice->selected_items->data) != item) { g_list_free (field_choice->selected_items); field_choice->selected_items = NULL; field_choice->selected_items = g_list_prepend (field_choice->selected_items, -- 2.43.5