From ea7e25ff1736b02f70ee593ba9cd645ed3fd9bad Mon Sep 17 00:00:00 2001 From: Jonathan Blandford Date: Sun, 19 Jun 2005 03:04:20 +0000 Subject: [PATCH] escape the text correctly. Handles non-UTF-8 properties and escaped Sat Jun 18 22:46:42 2005 Jonathan Blandford * shell/ev-properties.c (set_property): escape the text correctly. Handles non-UTF-8 properties and escaped properties. Also, sets the text to "None" if the property isn't set. * data/evince-properties.glade: Change the label to be ellipsized, and give it a minimum size. --- ChangeLog | 9 ++++++ data/evince-properties.glade | 48 ++++++++++++++--------------- shell/ev-properties.c | 59 +++++++++++++++++++++++++++++++++++- 3 files changed, 91 insertions(+), 25 deletions(-) diff --git a/ChangeLog b/ChangeLog index 64d0462a..ececb0b8 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,12 @@ +Sat Jun 18 22:46:42 2005 Jonathan Blandford + + * shell/ev-properties.c (set_property): escape the text correctly. + Handles non-UTF-8 properties and escaped properties. Also, sets + the text to "None" if the property isn't set. + + * data/evince-properties.glade: Change the label to be ellipsized, + and give it a minimum size. + 2005-06-19 Nickolay V. Shmyrev * lib/ev-file-helpers.c: (ev_file_helpers_shutdown): diff --git a/data/evince-properties.glade b/data/evince-properties.glade index 80423fa6..c18a08f7 100644 --- a/data/evince-properties.glade +++ b/data/evince-properties.glade @@ -422,8 +422,8 @@ 0.5 0 0 - PANGO_ELLIPSIZE_NONE - -1 + PANGO_ELLIPSIZE_END + 25 False 0 @@ -451,8 +451,8 @@ 0.5 0 0 - PANGO_ELLIPSIZE_NONE - -1 + PANGO_ELLIPSIZE_END + 25 False 0 @@ -480,8 +480,8 @@ 0.5 0 0 - PANGO_ELLIPSIZE_NONE - -1 + PANGO_ELLIPSIZE_END + 25 False 0 @@ -509,8 +509,8 @@ 0.5 0 0 - PANGO_ELLIPSIZE_NONE - -1 + PANGO_ELLIPSIZE_END + 25 False 0 @@ -538,8 +538,8 @@ 0.5 0 0 - PANGO_ELLIPSIZE_NONE - -1 + PANGO_ELLIPSIZE_END + 25 False 0 @@ -567,8 +567,8 @@ 0.5 0 0 - PANGO_ELLIPSIZE_NONE - -1 + PANGO_ELLIPSIZE_END + 25 False 0 @@ -596,8 +596,8 @@ 0.5 0 0 - PANGO_ELLIPSIZE_NONE - -1 + PANGO_ELLIPSIZE_END + 25 False 0 @@ -624,8 +624,8 @@ 0.5 0 0 - PANGO_ELLIPSIZE_NONE - -1 + PANGO_ELLIPSIZE_END + 25 False 0 @@ -652,8 +652,8 @@ 0.5 0 0 - PANGO_ELLIPSIZE_NONE - -1 + PANGO_ELLIPSIZE_END + 25 False 0 @@ -680,8 +680,8 @@ 0.5 0 0 - PANGO_ELLIPSIZE_NONE - -1 + PANGO_ELLIPSIZE_END + 25 False 0 @@ -708,8 +708,8 @@ 0.5 0 0 - PANGO_ELLIPSIZE_NONE - -1 + PANGO_ELLIPSIZE_END + 25 False 0 @@ -736,8 +736,8 @@ 0.5 0 0 - PANGO_ELLIPSIZE_NONE - -1 + PANGO_ELLIPSIZE_END + 25 False 0 diff --git a/shell/ev-properties.c b/shell/ev-properties.c index 0b9d8975..d7974c0f 100644 --- a/shell/ev-properties.c +++ b/shell/ev-properties.c @@ -33,6 +33,7 @@ #include #include #include +#include enum { @@ -171,15 +172,71 @@ ev_properties_format_date (GTime utime) return g_locale_to_utf8 (s, -1, NULL, NULL, NULL); } +/* This is cut out of gconvert.c from glib (and mildly modified). Not all + backends give valid UTF-8 for properties, so we make sure that is. + */ +static gchar * +make_valid_utf8 (const gchar *name) +{ + GString *string; + const gchar *remainder, *invalid; + gint remaining_bytes, valid_bytes; + + string = NULL; + remainder = name; + remaining_bytes = strlen (name); + + while (remaining_bytes != 0) + { + if (g_utf8_validate (remainder, remaining_bytes, &invalid)) + break; + valid_bytes = invalid - remainder; + + if (string == NULL) + string = g_string_sized_new (remaining_bytes); + + g_string_append_len (string, remainder, valid_bytes); + g_string_append_c (string, '?'); + + remaining_bytes -= valid_bytes + 1; + remainder = invalid + 1; + } + + if (string == NULL) + return g_strdup (name); + + g_string_append (string, remainder); + + g_assert (g_utf8_validate (string->str, -1, NULL)); + + return g_string_free (string, FALSE); +} + static void set_property (GladeXML *xml, Property property, const char *text) { GtkWidget *widget; + char *valid_text; widget = glade_xml_get_widget (xml, properties_info[property].label_id); g_return_if_fail (GTK_IS_LABEL (widget)); - gtk_label_set_text (GTK_LABEL (widget), text ? text : ""); + if (text == NULL || text[0] == '\000') { + gchar *markup; + + markup = g_markup_printf_escaped ("%s", _("None")); + gtk_label_set_markup (GTK_LABEL (widget), markup); + g_free (markup); + + return; + } + text = text ? text : ""; + + valid_text = make_valid_utf8 (text); + + gtk_label_set_text (GTK_LABEL (widget), valid_text); + + g_free (valid_text); } static void -- 2.43.5